[cfe-commits] r58419 - in /cfe/trunk: include/clang/Analysis/PathSensitive/GRExprEngine.h lib/Analysis/GRExprEngine.cpp

[Zhongxing Xu]

On Thu, Oct 30, 2008 at 1:18 PM, Ted Kremenek <kremenek at apple.com> wrote:

>
> On Oct 29, 2008, at 10:02 PM, Zhongxing Xu wrote:
>
>  +  if (T->isArrayType()) {
>> +    for (unsigned i = 0; i < NumInitElements; ++i) {
>> +      Expr* Init = E->getInit(i);
>> +      NodeSet Tmp;
>> +      Visit(Init, Pred, Tmp);
>>
>
> ....
>
>
>> +
>> +  if (T->isStructureType()) {
>> +    // FIXME: to be implemented.
>> +    MakeNode(Dst, E, Pred, state);
>> +    return;
>> +  }
>> +
>>
>
> Looks great.  Should these two cases be merged?  if (T->isArrayType() ||
> T->isStructureType())?
>

Yes. I'll do it in a later patch. Now I am renaming.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20081030/5937c190/attachment.html>