[cfe-commits] [PATCH] VisitInitListExpr

Ted Kremenek kremenek at apple.com
Wed Oct 29 21:06:33 PDT 2008


On Oct 29, 2008, at 9:00 PM, Zhongxing Xu wrote:

>
>
> +
> +void CompoundSValData::Profile(llvm::FoldingSetNodeID& ID, QualType  
> T,
> +                               unsigned N, const SVal* Vals) {
> +  T.Profile(ID);
> +  ID.AddInteger(N);
> +  for (unsigned i = 0; i < N; ++i)
> +    Vals[i].Profile(ID);
> +}
>
> You need the QualType in the profile as well, otherwise you might  
> get a collision.
>
>
> I did. It's in the first line T.Profile(ID).
>
> All others are good suggestions. Thanks.

Ah yes.  Missed it at the top.



More information about the cfe-commits mailing list