[cfe-commits] [PATCH] getLValueElement

[Zhongxing Xu]

New patch attached.

On Thu, Oct 23, 2008 at 9:28 AM, Ted Kremenek <kremenek at apple.com> wrote:

>
> On Oct 22, 2008, at 6:26 PM, Zhongxing Xu wrote:
>
>
>> This assertion will always be true.  Did you mean assert(false && "...")?
>>
>> No, I just don't want the program to crash when things happen, but also
>> put reminder there.
>>
>> Then it's not really an assertion.  Just use a comment.
>>
>> OK. I'll make it a comment. But I do see others doing this in Clang.
>>
>
> Those places are probably miswritten assertions.  When you spot them feel
> free to bring it to everyone's attention or submit a patch.
>
> Thanks Zhongxing!
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20081023/419a996d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: element2.patch
Type: application/octet-stream
Size: 2337 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20081023/419a996d/attachment.obj>