[cfe-commits] r57271 - in /cfe/trunk: include/clang/AST/StmtIterator.h lib/AST/StmtIterator.cpp

[Ted Kremenek]

Author: kremenek
Date: Tue Oct  7 18:04:14 2008
New Revision: 57271

URL: http://llvm.org/viewvc/llvm-project?rev=57271&view=rev
Log:
Add StmtIterator support for DeclGroups.

Modified:
    cfe/trunk/include/clang/AST/StmtIterator.h
    cfe/trunk/lib/AST/StmtIterator.cpp

Modified: cfe/trunk/include/clang/AST/StmtIterator.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/StmtIterator.h?rev=57271&r1=57270&r2=57271&view=diff

==============================================================================
--- cfe/trunk/include/clang/AST/StmtIterator.h (original)
+++ cfe/trunk/include/clang/AST/StmtIterator.h Tue Oct  7 18:04:14 2008
@@ -21,21 +21,32 @@
 
 class Stmt;
 class ScopedDecl;
+class Decl;
 class VariableArrayType;
   
 class StmtIteratorBase {
 protected:
-  enum { DeclMode = 0x1, SizeOfTypeVAMode = 0x2, Flags = 0x3 };
+  enum { DeclMode = 0x1, SizeOfTypeVAMode = 0x2, DeclGroupMode = 0x3,
+         Flags = 0x3 };
   
-  union { Stmt** stmt; ScopedDecl* decl; };
-  uintptr_t RawVAPtr;
+  union { Stmt** stmt; ScopedDecl* decl; Decl** DGI; };
+  uintptr_t RawVAPtr;  
+  Decl** DGE;
 
   bool inDecl() const {
-    return RawVAPtr & DeclMode ? true : false;
+    return (RawVAPtr & Flags) == DeclMode;
+  }
+  
+  bool inDeclGroup() const {
+    return (RawVAPtr & Flags) == DeclGroupMode;
   }
   
   bool inSizeOfTypeVA() const { 
-    return RawVAPtr & SizeOfTypeVAMode ? true : false;
+    return (RawVAPtr & Flags) == SizeOfTypeVAMode;
+  }
+  
+  bool inStmt() const {
+    return (RawVAPtr & Flags) == 0;
   }
     
   VariableArrayType* getVAPtr() const {
@@ -43,11 +54,12 @@
   }
   
   void setVAPtr(VariableArrayType* P) {
-    assert (inDecl() || inSizeOfTypeVA());    
+    assert (inDecl() || inDeclGroup() || inSizeOfTypeVA());    
     RawVAPtr = reinterpret_cast<uintptr_t>(P) | (RawVAPtr & Flags);
   }
   
   void NextDecl(bool ImmediateAdvance = true);
+  bool HandleDecl(Decl* D);
   void NextVA();
   
   Stmt*& GetDeclExpr() const;
@@ -55,6 +67,7 @@
   StmtIteratorBase(Stmt** s) : stmt(s), RawVAPtr(0) {}
   StmtIteratorBase(ScopedDecl* d);
   StmtIteratorBase(VariableArrayType* t);
+  StmtIteratorBase(Decl** dgi, Decl** dge);
   StmtIteratorBase() : stmt(NULL), RawVAPtr(0) {}
 };
   
@@ -69,16 +82,17 @@
 public:
   StmtIteratorImpl() {}                                                
   StmtIteratorImpl(Stmt** s) : StmtIteratorBase(s) {}
+  StmtIteratorImpl(Decl** dgi, Decl** dge) : StmtIteratorBase(dgi, dge) {}
   StmtIteratorImpl(ScopedDecl* d) : StmtIteratorBase(d) {}
   StmtIteratorImpl(VariableArrayType* t) : StmtIteratorBase(t) {}
   
   DERIVED& operator++() {
-    if (inDecl()) {
+    if (inDecl() || inDeclGroup()) {
       if (getVAPtr()) NextVA();
       else NextDecl();
     }
     else if (inSizeOfTypeVA())
-      NextVA();            
+      NextVA();
     else
       ++stmt;
       
@@ -100,7 +114,7 @@
   }
   
   REFERENCE operator*() const { 
-    return (REFERENCE) (inDecl() || inSizeOfTypeVA() ? GetDeclExpr() : *stmt);
+    return (REFERENCE) (inStmt() ? *stmt : GetDeclExpr());
   }
   
   REFERENCE operator->() const { return operator*(); }   
@@ -110,7 +124,9 @@
   explicit StmtIterator() : StmtIteratorImpl<StmtIterator,Stmt*&>() {}
 
   StmtIterator(Stmt** S) : StmtIteratorImpl<StmtIterator,Stmt*&>(S) {}
-  
+  StmtIterator(Decl** dgi, Decl** dge) 
+   : StmtIteratorImpl<StmtIterator,Stmt*&>(dgi, dge) {}
+
   StmtIterator(VariableArrayType* t):StmtIteratorImpl<StmtIterator,Stmt*&>(t) {}
   StmtIterator(ScopedDecl* D) : StmtIteratorImpl<StmtIterator,Stmt*&>(D) {}
 };

Modified: cfe/trunk/lib/AST/StmtIterator.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/StmtIterator.cpp?rev=57271&r1=57270&r2=57271&view=diff

==============================================================================
--- cfe/trunk/lib/AST/StmtIterator.cpp (original)
+++ cfe/trunk/lib/AST/StmtIterator.cpp Tue Oct  7 18:04:14 2008
@@ -35,12 +35,21 @@
   p = FindVA(p->getElementType().getTypePtr());
   setVAPtr(p);
 
-  if (!p && inDecl()) {
-    if (VarDecl* VD = dyn_cast<VarDecl>(decl)) 
-      if (VD->Init)
-        return;
+  if (!p) {
+    if (inDecl()) {
+      if (VarDecl* VD = dyn_cast<VarDecl>(decl)) 
+        if (VD->Init)
+          return;
+      
+      NextDecl();
+    }
+    else if (inDeclGroup()) {
+      if (VarDecl* VD = dyn_cast<VarDecl>(*DGI)) 
+        if (VD->Init)
+          return;
       
-    NextDecl();
+      NextDecl();  
+    }
   } else if (inSizeOfTypeVA()) {
     assert(!decl);
     RawVAPtr = 0;
@@ -48,45 +57,56 @@
 }
 
 void StmtIteratorBase::NextDecl(bool ImmediateAdvance) {
-  assert (inDecl());
   assert (getVAPtr() == NULL);
-  assert (decl);
-  
-  if (ImmediateAdvance) {
-    decl = decl->getNextDeclarator();
-
-    if (!decl) {
-      RawVAPtr = 0;
-      return;
-    }
-  }    
   
-  for ( ; decl ; decl = decl->getNextDeclarator()) {
-    if (VarDecl* VD = dyn_cast<VarDecl>(decl)) {        
-      if (VariableArrayType* VAPtr = FindVA(VD->getType().getTypePtr())) {
-        setVAPtr(VAPtr);
+  if (inDecl()) {
+    assert (decl);
+    
+    if (ImmediateAdvance)
+      decl = decl->getNextDeclarator();
+    
+    for ( ; decl ; decl = decl->getNextDeclarator())
+      if (HandleDecl(decl))
         return;
-      }
-      
-      if (VD->getInit())
-        return;    
-    }
-    else if (TypedefDecl* TD = dyn_cast<TypedefDecl>(decl)) {
-      if (VariableArrayType* VAPtr = 
-           FindVA(TD->getUnderlyingType().getTypePtr())) {
-        setVAPtr(VAPtr);
+  }
+  else {
+    assert (inDeclGroup());
+    
+    if (ImmediateAdvance)
+      ++DGI;
+    
+    for ( ; DGI != DGE; ++DGI)
+      if (HandleDecl(*DGI))
         return;
-      }
+  }
+
+  RawVAPtr = 0;
+}
+
+bool StmtIteratorBase::HandleDecl(Decl* D) {
+    
+  if (VarDecl* VD = dyn_cast<VarDecl>(D)) {        
+    if (VariableArrayType* VAPtr = FindVA(VD->getType().getTypePtr())) {
+      setVAPtr(VAPtr);
+      return true;
     }
-    else if (EnumConstantDecl* ECD = dyn_cast<EnumConstantDecl>(decl))
-      if (ECD->getInitExpr())
-        return;  
+        
+    if (VD->getInit())
+      return true;
   }
-  
-  if (!decl) {
-    RawVAPtr = 0;
-    return;
+  else if (TypedefDecl* TD = dyn_cast<TypedefDecl>(D)) {
+    if (VariableArrayType* VAPtr = 
+        FindVA(TD->getUnderlyingType().getTypePtr())) {
+      setVAPtr(VAPtr);
+      return true;
+    }
+  }
+  else if (EnumConstantDecl* ECD = dyn_cast<EnumConstantDecl>(D)) {
+    if (ECD->getInitExpr())
+      return true;
   }
+
+  return false;  
 }
 
 StmtIteratorBase::StmtIteratorBase(ScopedDecl* d)
@@ -95,16 +115,31 @@
   NextDecl(false);
 }
 
+StmtIteratorBase::StmtIteratorBase(Decl** dgi, Decl** dge)
+  : DGI(dgi), RawVAPtr(DeclGroupMode), DGE(dge) {
+  NextDecl(false);
+}
+
 StmtIteratorBase::StmtIteratorBase(VariableArrayType* t)
-: decl(NULL), RawVAPtr(SizeOfTypeVAMode) {
+: decl(0), RawVAPtr(SizeOfTypeVAMode) {
   RawVAPtr |= reinterpret_cast<uintptr_t>(t);
 }
 
 Stmt*& StmtIteratorBase::GetDeclExpr() const {
+  
+  if (inDeclGroup()) {
+    VarDecl* VD = cast<VarDecl>(*DGI);
+    return VD->Init;
+  }
+  
+  assert (inDecl() || inSizeOfTypeVA());
+  
   if (VariableArrayType* VAPtr = getVAPtr()) {
     assert (VAPtr->SizeExpr);
     return VAPtr->SizeExpr;
   }
+  
+  assert (inDecl());
 
   if (VarDecl* VD = dyn_cast<VarDecl>(decl)) {
     assert (VD->Init);