[cfe-commits] r56051 - /cfe/trunk/lib/CodeGen/CGCall.cpp

[Eli Friedman]

On Mon, Oct 6, 2008 at 8:28 AM, Matthijs Kooijman <matthijs at stdin.nl> wrote:
> Hi Daniel,
>
>>   - As a test, enable basic usage for some common x86-32 cases. This
>>     increases our x86-32 compliance (on other targets our compliance
>>     will just be broken in a different way).
> It seems that this coercion happening now is only correct for x86? For our
> (custom) backend, this is not wanted and even breaks (because this conversion
> of structs to integer return types confuses scalarrepl later on, after
> inlining).
>
> Would it make sense to do this in more per-backend manner, or at least allow
> the TargetInfo to disable this?

Doing this per-target is the intent... see
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20080915/007580.html.

Note that we must do this on a per-target basis because it affects the
correctness of the generated code.

-Eli