[cfe-commits] [PATCH] In CFGBuilder, reverse the RHSBlock of LogicalOp && and ||

Zhongxing Xu xuzhongxing at gmail.com
Fri Oct 3 23:26:50 PDT 2008


Applied.

On Sat, Oct 4, 2008 at 1:42 PM, Ted Kremenek <kremenek at apple.com> wrote:

> That's a subtle one.  Please apply immediately.
>
> Thanks Zhongxing!
>
>
> On Oct 3, 2008, at 9:06 PM, Zhongxing Xu wrote:
>
>  [xing at nc8430 clang]$ svn diff
>> Index: lib/AST/CFG.cpp
>> ===================================================================
>> --- lib/AST/CFG.cpp     (revision 57001)
>> +++ lib/AST/CFG.cpp     (working copy)
>> @@ -458,6 +458,7 @@
>>         Succ = ConfluenceBlock;
>>         Block = NULL;
>>         CFGBlock* RHSBlock = Visit(B->getRHS());
>> +        FinishBlock(RHSBlock);
>>
>>         // Now link the LHSBlock with RHSBlock.
>>         if (B->getOpcode() == BinaryOperator::LOr) {
>>
>>
>> Test case:
>>
>> void f() {
>>  int i;
>>  if (i >3 && (i < 10, i < 11)) {
>>    i = 10;
>>  }
>> }
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20081004/28dd84a9/attachment.html>


More information about the cfe-commits mailing list