[cfe-commits] r56007 - in /cfe/trunk: include/clang/Basic/DiagnosticKinds.def include/clang/Parse/Action.h include/clang/Parse/DeclSpec.h include/clang/Parse/Parser.h include/clang/Parse/Scope.h lib/Parse/ParseExprCXX.cpp lib/Parse/ParseStmt.cpp test/Parser/cxx-condition.cpp

[Argiris Kirtzidis]

Hi Neil,

Neil Booth wrote:
> Argiris Kirtzidis wrote:-
>
>   
>> Author: akirtzidis
>> Date: Tue Sep  9 15:38:47 2008
>> New Revision: 56007
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=56007&view=rev
>> Log:
>> Implement parser support for the 'condition' part of C++ selection-statements and iteration-statements (if/switch/while/for).
>> Add new 'ActOnCXXConditionDeclarationExpr' action, called when the 'condition' is a declaration instead of an expression.
>>     
>
> You've not updated the many comments about blocks for C++.
>   

I'll add more comments.

> Are you reading the standard as you implement it?
> C++ is not the same as C99 for scoping.
>   

Can you be more specific about what is wrong with the patch ?


-Argiris