[cfe-commits] [PATCH] Move the rest stuff into ConstraintManager

Ted Kremenek kremenek at apple.com
Thu Aug 28 22:46:43 PDT 2008

On Aug 27, 2008, at 11:16 PM, Zhongxing Xu wrote:

> This patch moves the rest of the symbolic analysis stuff into  
> BasicConstraintManager.
> - Zhongxing Xu
> <consteqty.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Hi Zhongxing,

Somehow I missed this patch when I went through my email today.

It looks pretty good!  The only concern I can spot right now is the  
commenting out of the pretty-printing of equality and inequality  
relationships.  That's a functionality regression that we shouldn't  
have, and generally we shouldn't be commenting out code (if we want to  
remove, we just remove it).  It's also an opportunity to generalize  
the functionality to allow pretty-printing of arbitrary constraints  
managed by the ConstraintManager.

It's clear that we will need to add a print method to  
ConstraintManager, similar to what we did with the StoreManager:

     virtual void print(Store store, std::ostream& Out, const char*  
nl, const char *sep) = 0;

Of course, in the case of ConstraintManager, we just pass the state  
instead of the store.

We can then move the pretty-printing logic for the inequality/equality  
relationships into BasicConstraintManager.  That seems like a small  
amendment to your patch, and would complete the migration of the  
functionality and improve the API.

Otherwise, great patch!


More information about the cfe-commits mailing list