[cfe-commits] r55211 - in /cfe/trunk/include/clang/Analysis/PathSensitive: Regions.h Store.h

[Chris Lattner]

On Aug 22, 2008, at 11:57 PM, Ted Kremenek wrote:
>>> URL: http://llvm.org/viewvc/llvm-project?rev=55211&view=rev
>>> Log:
>>> Added Regions.h: Regions define abstract memory locations for the  
>>> static analyzer.
>>
>> Hey Ted,
>>
>> Can you please use a more specific name?  How about MemRegion or  
>> SAMemRegion?
>
> Yeah, it is vague.  I'm not certain more letters though make it less  
> vague.  It's a technical term in itself.

I guess I didn't really mean that it was vague, just that it was  
ambiguous.  The word 'Region' can mean a lot of things in different  
contexts.

>> Since this is just in the clang namespace, it is somewhat strange  
>> to give it a global name like this.  Alternatively, for things  
>> specific to the static analyzer, how about using a clang::SA  
>> namespace?
>
> A separate namespace makes sense, and I've been thinking about  
> adding one for a while.

Ok

-Chris