[cfe-commits] r54364 - in /cfe/trunk: Driver/ASTConsumers.cpp Driver/ASTConsumers.h Driver/clang.cpp include/clang/CodeGen/ModuleBuilder.h lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/ModuleBuilder.cpp

[Matthijs Kooijman]

> After also discussing this with Daniel in person, I definitely think this 
> is the right approach.  Clients should be free to interrogate the 
> ASTConsumer after ParseAST has completed, and it is easy to make it the 
> client's responsibility to delete the ASTConsumer.  It will also force 
> people not to put logic in the destructor of an ASTConsumer other than 
> necessary cleanup.

This actually makes even more sense. I had assumed that there was some
compelling reason for putting that delete there, but apparently there isn't.
Thanks!

Gr.

Matthijs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20080808/71c244ff/attachment.sig>