[cfe-commits] r53987 - in /cfe/trunk: lib/Analysis/CheckObjCDealloc.cpp test/Analysis/IBOutlet.m test/Analysis/MissingDealloc_SEL.m

[Chris Lattner]

On Jul 24, 2008, at 10:45 AM, Ted Kremenek wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=53987&view=rev
> Log:
> Don't issue a missing +dealloc warning for classes that just contain  
> SEL ivars.
> This fixes PR 2592: http://llvm.org/bugs/show_bug.cgi?id=2592

Hi Ted,

I don't think this is the right fix.  Won't your checker still warn  
about other things like "int*" ivars?

>     if ((T->isPointerType() || T->isObjCQualifiedIdType()) &&
> +        (ID->getAttr<IBOutletAttr>() == 0 && // Skip IBOutlets.
> +         !isSEL(T, SelII))) { // Skip SEL ivars.
>       containsPointerIvar = true;

I think the right check should be what Sema::isObjCObjectPointerType  
does.  I think it would make sense to pull this out and put it on  
ASTContext or Type.  What do you think?

-Chris