[cfe-commits] r53942 - in /cfe/trunk: Driver/Analyses.def Driver/AnalysisConsumer.cpp include/clang/Analysis/LocalCheckers.h lib/Analysis/CheckObjCUnusedIVars.cpp
Ted Kremenek
kremenek at apple.com
Tue Jul 22 17:45:26 PDT 2008
Author: kremenek
Date: Tue Jul 22 19:45:26 2008
New Revision: 53942
URL: http://llvm.org/viewvc/llvm-project?rev=53942&view=rev
Log:
Add prototype implementation of unused ivar check.
Added:
cfe/trunk/lib/Analysis/CheckObjCUnusedIVars.cpp
Modified:
cfe/trunk/Driver/Analyses.def
cfe/trunk/Driver/AnalysisConsumer.cpp
cfe/trunk/include/clang/Analysis/LocalCheckers.h
Modified: cfe/trunk/Driver/Analyses.def
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/Driver/Analyses.def?rev=53942&r1=53941&r2=53942&view=diff
==============================================================================
--- cfe/trunk/Driver/Analyses.def (original)
+++ cfe/trunk/Driver/Analyses.def Tue Jul 22 19:45:26 2008
@@ -33,6 +33,9 @@
ANALYSIS(WarnObjCDealloc, "warn-objc-missing-dealloc",
"Warn about Objective-C classes that lack a correct implementation of -dealloc",
ObjCImplementation)
+
+ANALYSIS(WarnObjCUnusedIvars, "warn-objc-unused-ivars",
+ "Warn about private ivars that are never used", ObjCImplementation)
ANALYSIS(CheckerSimple, "checker-simple",
"Perform simple path-sensitive checks.", Code)
Modified: cfe/trunk/Driver/AnalysisConsumer.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/Driver/AnalysisConsumer.cpp?rev=53942&r1=53941&r2=53942&view=diff
==============================================================================
--- cfe/trunk/Driver/AnalysisConsumer.cpp (original)
+++ cfe/trunk/Driver/AnalysisConsumer.cpp Tue Jul 22 19:45:26 2008
@@ -393,6 +393,11 @@
mgr.getLangOptions(), BR);
}
+static void ActionWarnObjCUnusedIvars(AnalysisManager& mgr) {
+ BugReporter BR(mgr);
+ CheckObjCUnusedIvar(cast<ObjCImplementationDecl>(mgr.getCodeDecl()), BR);
+}
+
static void ActionWarnObjCMethSigs(AnalysisManager& mgr) {
BugReporter BR(mgr);
Modified: cfe/trunk/include/clang/Analysis/LocalCheckers.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/LocalCheckers.h?rev=53942&r1=53941&r2=53942&view=diff
==============================================================================
--- cfe/trunk/include/clang/Analysis/LocalCheckers.h (original)
+++ cfe/trunk/include/clang/Analysis/LocalCheckers.h Tue Jul 22 19:45:26 2008
@@ -45,6 +45,7 @@
BugReporter& BR);
void CheckObjCInstMethSignature(ObjCImplementationDecl* ID, BugReporter& BR);
+void CheckObjCUnusedIvar(ObjCImplementationDecl* D, BugReporter& BR);
void RegisterAppleChecks(GRExprEngine& Eng);
Added: cfe/trunk/lib/Analysis/CheckObjCUnusedIVars.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/CheckObjCUnusedIVars.cpp?rev=53942&view=auto
==============================================================================
--- cfe/trunk/lib/Analysis/CheckObjCUnusedIVars.cpp (added)
+++ cfe/trunk/lib/Analysis/CheckObjCUnusedIVars.cpp Tue Jul 22 19:45:26 2008
@@ -0,0 +1,87 @@
+//==- CheckObjCUnusedIVars.cpp - Check for unused ivars ----------*- C++ -*-==//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// This file defines a CheckObjCUnusedIvars, a checker that
+// analyzes an Objective-C class's interface/implementation to determine if it
+// has any ivars that are never accessed.
+//
+//===----------------------------------------------------------------------===//
+
+#include "clang/Analysis/LocalCheckers.h"
+#include "clang/Analysis/PathDiagnostic.h"
+#include "clang/Analysis/PathSensitive/BugReporter.h"
+#include "clang/AST/ExprObjC.h"
+#include "clang/AST/Expr.h"
+#include "clang/AST/DeclObjC.h"
+#include "clang/Basic/LangOptions.h"
+#include <sstream>
+
+using namespace clang;
+
+enum IVarState { Unused, Used };
+typedef llvm::DenseMap<ObjCIvarDecl*,IVarState> IvarUsageMap;
+
+static void Scan(IvarUsageMap& M, Stmt* S) {
+ if (!S)
+ return;
+
+ if (ObjCIvarRefExpr* Ex = dyn_cast<ObjCIvarRefExpr>(S)) {
+ ObjCIvarDecl* D = Ex->getDecl();
+ IvarUsageMap::iterator I = M.find(D);
+ if (I != M.end()) I->second = Used;
+ }
+ else
+ for (Stmt::child_iterator I=S->child_begin(), E=S->child_end(); I!=E;++I)
+ Scan(M, *I);
+}
+
+void clang::CheckObjCUnusedIvar(ObjCImplementationDecl* D, BugReporter& BR) {
+
+ ObjCInterfaceDecl* ID = D->getClassInterface();
+ IvarUsageMap M;
+
+
+
+ // Iterate over the ivars.
+ for (ObjCInterfaceDecl::ivar_iterator I=ID->ivar_begin(), E=ID->ivar_end();
+ I!=E; ++I) {
+
+ ObjCIvarDecl* ID = *I;
+
+ // Ignore ivars that aren't private.
+ ObjCIvarDecl::AccessControl ac = ID->getAccessControl();
+ if (!(ac == ObjCIvarDecl::None || ac == ObjCIvarDecl::Private))
+ continue;
+
+ if (ID->getAttr<IBOutletAttr>() == 0)
+ continue;
+
+ M[ID] = Unused;
+ }
+
+ if (M.empty())
+ return;
+
+ // Now scan the methods for accesses.
+ for (ObjCImplementationDecl::instmeth_iterator I = D->instmeth_begin(),
+ E = D->instmeth_end(); I!=E; ++I)
+ Scan(M, (*I)->getBody());
+
+ // Find ivars that are unused.
+ for (IvarUsageMap::iterator I = M.begin(), E = M.end(); I!=E; ++I)
+ if (I->second == Unused) {
+
+ std::ostringstream os;
+ os << "Private ivar '" << I->first->getName() << "' is never used.";
+
+ BR.EmitBasicReport("unused ivar",
+ os.str().c_str(), I->first->getLocation());
+ }
+}
+
More information about the cfe-commits
mailing list