[cfe-commits] r53499 - in /cfe/trunk: include/clang/Basic/DiagnosticKinds.def lib/AST/ExprConstant.cpp

[Eli Friedman]

On Fri, Jul 11, 2008 at 5:14 PM, Chris Lattner <sabre at nondot.org> wrote:
> Author: lattner
> Date: Fri Jul 11 19:14:42 2008
> New Revision: 53499
>
> URL: http://llvm.org/viewvc/llvm-project?rev=53499&view=rev
> Log:
> start remembering diagnostics for various cases, add some missing
> code.  Switch to Eli's getIntWidth method.

Mmm, just a few comments:

Should we return a diagnostic for operators with side effects, even if
they aren't evaluated?  It seems like an interesting thing to know,
even if what we do here doesn't affect the C99 ICE case.

We should also return some sort of diagnostic for illegal shifts (I'm
thinking it should be an error, but I don't have a strong opinion
either way).

What should happen when there are multiple diagnostics?  The current
code tosses out all but the most recent diagnostic.

-Eli