[cfe-commits] r53074 - in /cfe/trunk: clang.xcodeproj/project.pbxproj include/clang/AST/APValue.h include/clang/AST/Expr.h lib/AST/Expr.cpp lib/AST/ExprConstant.cpp lib/Sema/SemaDecl.cpp

Eli Friedman eli.friedman at gmail.com
Wed Jul 2 21:56:16 PDT 2008


On Wed, Jul 2, 2008 at 9:20 PM, Anders Carlsson <andersca at mac.com> wrote:
> Author: andersca
> Date: Wed Jul  2 23:20:39 2008
> New Revision: 53074
>
> URL: http://llvm.org/viewvc/llvm-project?rev=53074&view=rev
> Log:
> Shuffle things around in preparation for integrating Eli's constant evaluator.

Okay, looks good.  (The thought crossed my mind that we might want to
put this on ASTContext rather than Expr, but it doesn't really
matter.)

Something I thought of just now: how do we want to represent a pointer
expression that's an offset from the null pointer?  Using a null Expr*
+ offset?  Or as an APSInt?  I'm thinking a null Expr*+offset is more
consistent/intuitive, but I thought I'd mention it in case someone can
think of a case where an APSInt representation would be more
useful/easier to deal with.

-Eli



More information about the cfe-commits mailing list