[cfe-commits] r52879 - in /cfe/trunk/lib/Sema: Sema.h SemaDeclAttr.cpp

[Argiris Kirtzidis]

Chris Lattner wrote:
> On Tue, 1 Jul 2008, Argiris Kirtzidis wrote:
>>>  URL: http://llvm.org/viewvc/llvm-project?rev=52879&view=rev
>>>  Log:
>>>  make most of Sema public.  Sema is a class private to the Sema 
>>> library  anyway, so there is no real loss here.
>>
>> In general, wouldn't it be useful to have Sema class public to the 
>> Sema library ?
>> It would allow specialized action modules that also require full 
>> semantic analysis; in such a case it'd be useful to subclass and 
>> extend a few methods of the Sema class.
>
> I'm not sure what you mean.  Since the Sema class is private to the 
> Sema library, I'm fine with all of its members being public.  Is that 
> what you mean?

I'm talking about having Sema class "public" to client code, meaning 
moving Sema.h from 'lib/Sema' into 'include/clang/Sema'. Are there 
issues with this approach ?


-Argiris