[cfe-commits] r51964 - in /cfe/trunk: lib/Sema/SemaExprObjC.cpp test/Sema/objc-comptypes-9.m

[Ted Kremenek]

Author: kremenek
Date: Wed Jun  4 15:48:08 2008
New Revision: 51964

URL: http://llvm.org/viewvc/llvm-project?rev=51964&view=rev
Log:
Added fixmes.

Modified:
    cfe/trunk/lib/Sema/SemaExprObjC.cpp
    cfe/trunk/test/Sema/objc-comptypes-9.m

Modified: cfe/trunk/lib/Sema/SemaExprObjC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprObjC.cpp?rev=51964&r1=51963&r2=51964&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaExprObjC.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExprObjC.cpp Wed Jun  4 15:48:08 2008
@@ -339,6 +339,8 @@
     // In gcc, it is also allowed assigning a protocol-qualified 'id'
     // type to a LHS object when protocol in qualified LHS is in list
     // of protocols in the rhs 'id' object. This IMO, should be a bug.
+    // FIXME: Treat this as an extension, and flag this as an error when
+    //  GCC extensions are not enabled.
     else if (RHSIsQualifiedID &&
              ProtocolCompatibleWithProtocol(protoList[i], lProto))
       return true;

Modified: cfe/trunk/test/Sema/objc-comptypes-9.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/objc-comptypes-9.m?rev=51964&r1=51963&r2=51964&view=diff

==============================================================================
--- cfe/trunk/test/Sema/objc-comptypes-9.m (original)
+++ cfe/trunk/test/Sema/objc-comptypes-9.m Wed Jun  4 15:48:08 2008
@@ -1,4 +1,6 @@
 // RUN: clang -fsyntax-only %s
+// FIXME: This test case tests the patch applied in: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20080602/006017.html
+//   Eventually that logic should be treated as an extension.
 
 typedef signed char BOOL;
 typedef int NSInteger;