[cfe-commits] r51312 - /cfe/trunk/lib/CodeGen/CodeGenModule.cpp

[Eli Friedman]

Author: efriedma
Date: Tue May 20 04:21:07 2008
New Revision: 51312

URL: http://llvm.org/viewvc/llvm-project?rev=51312&view=rev
Log:
Disable the function address cache; this doesn't have any ill effects, 
as far as I can tell, and it fixes code like test/CodeGen/functions.c.

(Whatever performance effect it might have, crashing on a 
construct like this isn't really acceptable; I've run into this 
multiple times.)


Modified:
    cfe/trunk/lib/CodeGen/CodeGenModule.cpp

Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=51312&r1=51311&r2=51312&view=diff

==============================================================================
--- cfe/trunk/lib/CodeGen/CodeGenModule.cpp (original)
+++ cfe/trunk/lib/CodeGen/CodeGenModule.cpp Tue May 20 04:21:07 2008
@@ -168,8 +168,11 @@
                                                      bool isDefinition) {
   // See if it is already in the map.  If so, just return it.
   llvm::Constant *&Entry = GlobalDeclMap[D];
+#if 0
+  // FIXME: The cache is currently broken!
   if (Entry) return Entry;
-  
+#endif
+
   const llvm::Type *Ty = getTypes().ConvertType(D->getType());
   
   // Check to see if the function already exists.