[cfe-commits] r51068 - in /cfe/trunk: include/clang/AST/Expr.h lib/AST/Expr.cpp lib/CodeGen/CGExpr.cpp

[Chris Lattner]

On May 13, 2008, at 2:03 PM, Nate Begeman wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=51068&view=rev
> Log:
> Remove AST dependency on VMCore by switching ExtVectorElementExpr  
> off Constant.

Nice!

>
> +++ cfe/trunk/include/clang/AST/Expr.h Tue May 13 16:03:02 2008
> @@ -722,12 +721,11 @@
>
>   /// getEncodedElementAccess - Encode the elements accessed into an  
> llvm
>   /// aggregate Constant of ConstantInt(s).
> -  llvm::Constant *getEncodedElementAccess() const;
> +  void getEncodedElementAccess(llvm::SmallVectorImpl<unsigned>  
> &Elts) const;

This is great.

>
>
>   /// getAccessedFieldNo - Given an encoded value and a result  
> number, return
>   /// the input field number being accessed.
> +  static unsigned getAccessedFieldNo(unsigned Idx, const  
> llvm::Constant *Elts);

... but this still uses llvm::Constant in the AST?  Can this be moved  
to be a method in CodeGen?

-Chris