[cfe-commits] r50197 - /cfe/trunk/lib/Analysis/BugReporter.cpp

[Ted Kremenek]

On May 4, 2008, at 2:21 PM, Chris Lattner wrote:

>
> On Apr 23, 2008, at 11:05 PM, Ted Kremenek wrote:
>
>>
>> On Apr 23, 2008, at 5:56 PM, Chris Lattner wrote:
>>
>>>
>>> On Apr 23, 2008, at 4:35 PM, Ted Kremenek wrote:
>>>
>>>> Author: kremenek
>>>> Date: Wed Apr 23 18:35:07 2008
>>>> New Revision: 50197
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=50197&view=rev
>>>> Log:
>>>> For case statements involving enums, BugReporter now generates  
>>>> PathDiagnostics
>>>> that say that we are jumping to "case a" instead of "case 0".
>>>>
>>>> This is a feature implementation for <rdar://problem/5880430>.
>>>
>>> Nifty, is there any way to write regtests for these sorts of  
>>> presentation issues?
>>>
>>> -Chris
>>
>> I think so.  Checking the status code of grep?
>
> Can you use 'expected-warning {{..}}' syntax with the non-html  
> diagnostic emitter?

Yes, but for non-html diagnostics we only emit diagnostics for the  
last piece of the path, not the entire path.  We can easily write a  
"PathTextDiagnostic" that renders an entire path as diagnostics for  
the TextDiagnosticClient (which could then be verified).