[cfe-commits] r49767 - /cfe/trunk/lib/Rewrite/HTMLRewrite.cpp

[Chris Lattner]

Author: lattner
Date: Tue Apr 15 23:11:35 2008
New Revision: 49767

URL: http://llvm.org/viewvc/llvm-project?rev=49767&view=rev
Log:
switch AddLineNumber to use a SmallString instead of sstream.  This
speeds up -emit-html on ted's testcase by 29% (.138 -> 0.107s) in a
release build.


Modified:
    cfe/trunk/lib/Rewrite/HTMLRewrite.cpp

Modified: cfe/trunk/lib/Rewrite/HTMLRewrite.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Rewrite/HTMLRewrite.cpp?rev=49767&r1=49766&r2=49767&view=diff

==============================================================================
--- cfe/trunk/lib/Rewrite/HTMLRewrite.cpp (original)
+++ cfe/trunk/lib/Rewrite/HTMLRewrite.cpp Tue Apr 15 23:11:35 2008
@@ -15,6 +15,7 @@
 #include "clang/Rewrite/Rewriter.h"
 #include "clang/Rewrite/HTMLRewrite.h"
 #include "clang/Basic/SourceManager.h"
+#include "llvm/ADT/SmallString.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include <sstream>
 
@@ -113,17 +114,18 @@
 
 static void AddLineNumber(Rewriter& R, unsigned LineNo,
                           SourceLocation B, SourceLocation E) {
-    
-  std::ostringstream os;
-  os << "<tr><td class=\"num\" id=\"LN" << LineNo << "\">" 
-     << LineNo << "</td><td class=\"line\">";
-
+  llvm::SmallString<100> Str;
+  Str += "<tr><td class=\"num\" id=\"LN";
+  Str.append_uint(LineNo);
+  Str += "\">";
+  Str.append_uint(LineNo);
+  Str += "</td><td class=\"line\">";
+  
   if (B == E) { // Handle empty lines.
-    os << " </td></tr>";
-    R.InsertStrBefore(B, os.str());
-  }
-  else {
-    R.InsertStrBefore(B, os.str());
+    Str += " </td></tr>";
+    R.InsertTextBefore(B, &Str[0], Str.size());
+  } else {
+    R.InsertTextBefore(B, &Str[0], Str.size());
     R.InsertCStrBefore(E, "</td></tr>");
   }
 }