[cfe-commits] r49558 - /cfe/trunk/lib/Analysis/CFRefCount.cpp

[Ted Kremenek]

Author: kremenek
Date: Fri Apr 11 15:51:02 2008
New Revision: 49558

URL: http://llvm.org/viewvc/llvm-project?rev=49558&view=rev
Log:
Added FIXME

Modified:
    cfe/trunk/lib/Analysis/CFRefCount.cpp

Modified: cfe/trunk/lib/Analysis/CFRefCount.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/CFRefCount.cpp?rev=49558&r1=49557&r2=49558&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/CFRefCount.cpp (original)
+++ cfe/trunk/lib/Analysis/CFRefCount.cpp Fri Apr 11 15:51:02 2008
@@ -693,9 +693,13 @@
           break;
         }
       }
-    }
-    else if (isa<LVal>(V)) // Nuke all arguments passed by reference.
+    }  
+    else if (isa<LVal>(V)) { // Nuke all arguments passed by reference.
+      
+      // FIXME: This is basically copy-and-paste from GRSimpleVals.  We 
+      //  should compose behavior, not copy it.
       StateMgr.Unbind(StVals, cast<LVal>(V));
+    }
   }    
     
   if (hasError) {
@@ -733,6 +737,8 @@
     case RetEffect::NoRet:
     
       // Make up a symbol for the return value (not reference counted).
+      // FIXME: This is basically copy-and-paste from GRSimpleVals.  We 
+      //  should compose behavior, not copy it.
       
       if (CE->getType() != Eng.getContext().VoidTy) {    
         unsigned Count = Builder.getCurrentBlockCount();