[cfe-commits] r49506 - in /cfe/trunk: include/clang/Parse/Action.h lib/Parse/ParseDecl.cpp lib/Parse/ParseObjc.cpp lib/Sema/Sema.h lib/Sema/SemaDecl.cpp

[Fariborz Jahanian]

Done. See below.

- Fariborz

On Apr 10, 2008, at 11:38 PM, Chris Lattner wrote:
>
>>
>> +  IdentifierInfo *II = D.getIdentifier();
>> +  Expr *BitWidth = (Expr*)BitfieldWidth;
>> +  SourceLocation Loc = DeclStart;
>> +  if (II) Loc = D.getIdentifierLoc();
>
> Can ivars be bitfields?  If not, they should just be rejected.

Yes. Ivars are no different than c's structure field decls.

>
>
>> +
>> +  // FIXME: Unnamed fields can be handled in various different  
>> ways, for
>> +  // example, unnamed unions inject all members into the struct  
>> namespace!
>
> This needs to be updated.  Can ivars be unnamed?

See above.

>
>
>> +  if (BitWidth) {
>> +    // TODO: Validate.
>> +    //printf("WARNING: BITFIELDS IGNORED!\n");
>> +
>> +    // 6.7.2.1p3
>> +    // 6.7.2.1p4
>> +
>> +  } else {
>> +    // Not a bitfield.
>> +
>> +    // validate II.
>> +
>> +  }
>
> This should probably go away.

See above.

Down the road, I want to consolidate the common part of the two ActOn  
routines into one.

- Fariborz