[cfe-commits] [patch] fix PR2081 (for review)

Chris Lattner clattner at apple.com
Fri Mar 7 16:48:33 PST 2008


On Mar 5, 2008, at 12:09 PM, Lauro Ramos Venancio wrote:
> I've improved a few the patch. It is not needed to use PATypeHolder in
> "PointersToResolve" vector.

This patch looks great to me.  Please improve the comments above  
ConvertType and ConvertTypeRecursive though.  Specifically, please  
mention that ConvertTypeRecursive should not be called by anything  
other than itself and ConvertType.  Above ConvertType, please explain  
what the code is doing.

Thanks Lauro!

-Chris

>
>
> Lauro
>
> Em 04/03/08, Lauro Ramos Venancio<lauro.venancio at gmail.com> escreveu:
>> PR2081: http://llvm.org/bugs/show_bug.cgi?id=2081
>>
>>
>> Lauro
>>
>>
> <pr2081.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list