[cfe-commits] plug a memory leak in the -E code

Chris Lattner clattner at apple.com
Mon Mar 3 13:17:05 PST 2008


On Mar 3, 2008, at 9:18 AM, Sam Bishop wrote:

> When clang is acting on the -E option, it creates a
> PrintPPOutputPPCallbacks object but never deletes it.  The object is
> passed to the Preprocessor object, but it doesn't delete it either.
>
> It seems to me that the Driver code ought to do the deleting.  So I  
> have
> attached a patch which does just that.

Nice catch.  However, I think it makes more sense for the PP to take  
ownership of the callbacks object.  What do you think?

-Chris



More information about the cfe-commits mailing list