[cfe-commits] r47489 - /cfe/trunk/Analysis/GRSimpleVals.cpp

[Ted Kremenek]

Author: kremenek
Date: Fri Feb 22 12:41:59 2008
New Revision: 47489

URL: http://llvm.org/viewvc/llvm-project?rev=47489&view=rev
Log:
Punt on unifying symbolic lvalues.  This won't be needed for many checkers.

Modified:
    cfe/trunk/Analysis/GRSimpleVals.cpp

Modified: cfe/trunk/Analysis/GRSimpleVals.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/Analysis/GRSimpleVals.cpp?rev=47489&r1=47488&r2=47489&view=diff

==============================================================================
--- cfe/trunk/Analysis/GRSimpleVals.cpp (original)
+++ cfe/trunk/Analysis/GRSimpleVals.cpp Fri Feb 22 12:41:59 2008
@@ -225,11 +225,12 @@
         return nonlval::SymIntConstraintVal(C);
       }
       
-      // FIXME: Implement unification
-      return UnknownVal();
-        //assert (!isa<lval::SymbolVal>(R) && "FIXME: Implement unification.");
-      
-      break;
+      // FIXME: Implement == for lval Symbols.  This is mainly useful
+      //  in iterator loops when traversing a buffer, e.g. while(z != zTerm).
+      //  Since this is not useful for many checkers we'll punt on this for 
+      //  now.
+       
+      return UnknownVal();      
     }
       
     case lval::DeclValKind:
@@ -278,7 +279,12 @@
         return nonlval::SymIntConstraintVal(C);
       }
       
-      assert (!isa<lval::SymbolVal>(R) && "FIXME: Implement sym !=.");
+      // FIXME: Implement != for lval Symbols.  This is mainly useful
+      //  in iterator loops when traversing a buffer, e.g. while(z != zTerm).
+      //  Since this is not useful for many checkers we'll punt on this for 
+      //  now.
+      
+      return UnknownVal();
       
       break;
     }