[cfe-commits] r47436 - /cfe/trunk/Basic/Targets.cpp

[Eli Friedman]

On Thu, Feb 21, 2008 at 8:29 AM, Gabor Greif <ggreif at gmail.com> wrote:
>  But in result "make test" now passes
>  a lot of tests, the notable exceptions
>  being the objc rewrite tests

Probably it's not finding the objc headers.

>  and mandel.c.

If you're using glibc, that's known broken, and unfixable without
making clang non-C99 compliant.  If you're not, I'd be interested in
seeing the preprocessed source.

>  +// FIXME: we need a real target configuration system.  For now, only define
>  +// __SUN__ if the host has it.
>  +#ifdef __SUN__
>  +    Define(Defs, "__SUN__");
>  +    Define(Defs, "__SOLARIS__");
>  +#endif

This should be done based on the target triple.  Then again, it might
not be worth bothering, considering this whole file is going to have
to be rewritten at some point.

-Eli