[cfe-commits] r46897 - in /cfe/trunk: Driver/TextDiagnosticPrinter.cpp Driver/TextDiagnosticPrinter.h Sema/Sema.h Sema/SemaDeclObjC.cpp include/clang/Basic/DiagnosticKinds.def test/Sema/method-undef-category-warn-1.m test/Sema/method-undefined-warn-1.m test/Sema/undef-protocol-methods-1.m

[Chris Lattner]

>> This (and other instances) could be simplified to:
>> if (!IncompleteImpl)  // Emit the incomplete impl warning only once.
>> IncompleteImpl = Diag(ImpLoc, diag::warn_incomplete_impl);
>>
>
> I just added a helper for this (without seeing your email  
> above...weird timing:-).
>
> I think the helper is cleaner (since it keeps the message in one  
> place...instead of 6).
>
> I could hack the helper to do as you say, however it's less  
> important (since the helper is simple).

I agree, the helper is even better, thanks!

-Chris