[cfe-commits] r46910 - in /cfe/trunk: Parse/ParseStmt.cpp include/clang/Parse/Parser.h test/Parser/asm.c

[Anders Carlsson]

Author: andersca
Date: Sat Feb  9 13:57:29 2008
New Revision: 46910

URL: http://llvm.org/viewvc/llvm-project?rev=46910&view=rev
Log:
Behave correctly if a constraint expression is invalid.

Modified:
    cfe/trunk/Parse/ParseStmt.cpp
    cfe/trunk/include/clang/Parse/Parser.h
    cfe/trunk/test/Parser/asm.c

Modified: cfe/trunk/Parse/ParseStmt.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/Parse/ParseStmt.cpp?rev=46910&r1=46909&r2=46910&view=diff

==============================================================================
--- cfe/trunk/Parse/ParseStmt.cpp (original)
+++ cfe/trunk/Parse/ParseStmt.cpp Sat Feb  9 13:57:29 2008
@@ -995,12 +995,15 @@
     RParenLoc = ConsumeParen();
   } else {
     // Parse Outputs, if present. 
-    ParseAsmOperandsOpt(Names, Constraints, Exprs);
+    if (ParseAsmOperandsOpt(Names, Constraints, Exprs))
+        return true;
   
     NumOutputs = Names.size();
   
     // Parse Inputs, if present.
-    ParseAsmOperandsOpt(Names, Constraints, Exprs);
+    if (ParseAsmOperandsOpt(Names, Constraints, Exprs))
+        return true;
+      
     assert(Names.size() == Constraints.size() &&
            Constraints.size() == Exprs.size() 
            && "Input operand size mismatch!");
@@ -1048,16 +1051,16 @@
 ///         asm-string-literal '(' expression ')'
 ///         '[' identifier ']' asm-string-literal '(' expression ')'
 ///
-void Parser::ParseAsmOperandsOpt(llvm::SmallVectorImpl<std::string> &Names,
+bool Parser::ParseAsmOperandsOpt(llvm::SmallVectorImpl<std::string> &Names,
                                  llvm::SmallVectorImpl<ExprTy*> &Constraints,
                                  llvm::SmallVectorImpl<ExprTy*> &Exprs) {
   // Only do anything if this operand is present.
-  if (Tok.isNot(tok::colon)) return;
+  if (Tok.isNot(tok::colon)) return false;
   ConsumeToken();
   
   // 'asm-operands' isn't present?
   if (!isTokenStringLiteral() && Tok.isNot(tok::l_square))
-    return;
+    return false;
   
   while (1) {   
     // Read the [id] if present.
@@ -1067,7 +1070,7 @@
       if (Tok.isNot(tok::identifier)) {
         Diag(Tok, diag::err_expected_ident);
         SkipUntil(tok::r_paren);
-        return;
+        return true;
       }
       
       IdentifierInfo *II = Tok.getIdentifierInfo();
@@ -1081,27 +1084,29 @@
     ExprResult Constraint = ParseAsmStringLiteral();
     if (Constraint.isInvalid) {
         SkipUntil(tok::r_paren);
-        return;
+        return true;
     }
     Constraints.push_back(Constraint.Val);
 
     if (Tok.isNot(tok::l_paren)) {
       Diag(Tok, diag::err_expected_lparen_after, "asm operand");
       SkipUntil(tok::r_paren);
-      return;
+      return true;
     }
     
     // Read the parenthesized expression.
     ExprResult Res = ParseSimpleParenExpression();
     if (Res.isInvalid) {
       SkipUntil(tok::r_paren);
-      return;
+      return true;
     }
     Exprs.push_back(Res.Val);
     // Eat the comma and continue parsing if it exists.
-    if (Tok.isNot(tok::comma)) return;
+    if (Tok.isNot(tok::comma)) return false;
     ConsumeToken();
   }
+
+  return true;
 }
 
 Parser::DeclTy *Parser::ParseFunctionStatementBody(DeclTy *Decl, 

Modified: cfe/trunk/include/clang/Parse/Parser.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Parse/Parser.h?rev=46910&r1=46909&r2=46910&view=diff

==============================================================================
--- cfe/trunk/include/clang/Parse/Parser.h (original)
+++ cfe/trunk/include/clang/Parse/Parser.h Sat Feb  9 13:57:29 2008
@@ -410,7 +410,7 @@
   StmtResult ParseObjCTryStmt(SourceLocation atLoc, bool &processAtKeyword);
   StmtResult ParseObjCThrowStmt(SourceLocation atLoc);
   StmtResult ParseObjCSynchronizedStmt(SourceLocation atLoc);
-  void ParseAsmOperandsOpt(llvm::SmallVectorImpl<std::string> &Names,
+  bool ParseAsmOperandsOpt(llvm::SmallVectorImpl<std::string> &Names,
                            llvm::SmallVectorImpl<ExprTy*> &Constraints,
                            llvm::SmallVectorImpl<ExprTy*> &Exprs);
 

Modified: cfe/trunk/test/Parser/asm.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Parser/asm.c?rev=46910&r1=46909&r2=46910&view=diff

==============================================================================
--- cfe/trunk/test/Parser/asm.c (original)
+++ cfe/trunk/test/Parser/asm.c Sat Feb  9 13:57:29 2008
@@ -3,3 +3,8 @@
 void f1() {
   asm ("ret" : : :); // expected-error {{expected string literal}}
 }
+
+void f2() {
+  asm("foo" : "=r" (a)); // expected-error {{use of undeclared identifier 'a'}}
+  asm("foo" : : "r" (b)); // expected-error {{use of undeclared identifier 'b'}} 
+}