[cfe-commits] r46782 - /cfe/trunk/Parse/ParseObjc.cpp

Steve Naroff snaroff at apple.com
Tue Feb 5 15:59:27 PST 2008


Author: snaroff
Date: Tue Feb  5 17:59:27 2008
New Revision: 46782

URL: http://llvm.org/viewvc/llvm-project?rev=46782&view=rev
Log:

Add a FIXME to clarify previous commit/experiment.


Modified:
    cfe/trunk/Parse/ParseObjc.cpp

Modified: cfe/trunk/Parse/ParseObjc.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/Parse/ParseObjc.cpp?rev=46782&r1=46781&r2=46782&view=diff

==============================================================================
--- cfe/trunk/Parse/ParseObjc.cpp (original)
+++ cfe/trunk/Parse/ParseObjc.cpp Tue Feb  5 17:59:27 2008
@@ -1267,6 +1267,12 @@
     bool parsedAtSign;
     
     StmtResult Res = ParseObjCTryStmt(AtLoc, parsedAtSign);
+    // FIXME: This hack results in a dropped AST node. To correctly implement 
+    // the hack, parseAtSign would need to bubble up to 
+    // ParseCompoundStatement(). This would involve adding an argument to this 
+    // routine and ParseStatementOrDeclaration(). Changing the parser in this
+    // fashion to solve such a conceptually simple problem is undesirable.
+    // Rework this clause once 2-token lookahead is implemented.
     if (!Res.isInvalid && parsedAtSign)
       return ParseObjCAtStatement(AtLoc);
     return Res;





More information about the cfe-commits mailing list