[cfe-commits] r46380 - in /cfe/trunk: AST/CFG.cpp Analysis/UninitializedValues.cpp

[Ted Kremenek]

Author: kremenek
Date: Fri Jan 25 18:03:27 2008
New Revision: 46380

URL: http://llvm.org/viewvc/llvm-project?rev=46380&view=rev
Log:
Added back logic in patch r46361 (http://llvm.org/viewvc/llvm-project?rev=46361&view=rev) with the addition of
some previously missing NULL pointer checks.

Modified the UninitializedValues analysis to not expect that every Expr* at the
block-level is a block-level expression (we probably need to change the name of
such expressions to something truer to their meaning).

Modified:
    cfe/trunk/AST/CFG.cpp
    cfe/trunk/Analysis/UninitializedValues.cpp

Modified: cfe/trunk/AST/CFG.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/AST/CFG.cpp?rev=46380&r1=46379&r2=46380&view=diff

==============================================================================
--- cfe/trunk/AST/CFG.cpp (original)
+++ cfe/trunk/AST/CFG.cpp Fri Jan 25 18:03:27 2008
@@ -991,26 +991,58 @@
   typedef llvm::DenseMap<const Stmt*,unsigned> BlkExprMapTy;
 }
 
+static void FindSubExprAssignments(Stmt* S, llvm::SmallPtrSet<Expr*,50>& Set) {
+  if (!S)
+    return;
+  
+  for (Stmt::child_iterator I=S->child_begin(), E=S->child_end(); I!=E; ++I) {
+    if (!*I) continue;
+    
+    if (BinaryOperator* B = dyn_cast<BinaryOperator>(*I))
+      if (B->isAssignmentOp()) Set.insert(B);
+    
+    FindSubExprAssignments(*I, Set);
+  }
+}
+
 static BlkExprMapTy* PopulateBlkExprMap(CFG& cfg) {
   BlkExprMapTy* M = new BlkExprMapTy();
   
+  // Look for assignments that are used as subexpressions.  These are the
+  // only assignments that we want to register as a block-level expression.
+  llvm::SmallPtrSet<Expr*,50> SubExprAssignments;
+  
   for (CFG::iterator I=cfg.begin(), E=cfg.end(); I != E; ++I)
     for (CFGBlock::iterator BI=I->begin(), EI=I->end(); BI != EI; ++BI)
-      if (const Expr* E = dyn_cast<Expr>(*BI)) {
-        unsigned x = M->size();
-        (*M)[E] = x;
+      FindSubExprAssignments(*BI, SubExprAssignments);
 
-        // Special handling for statement expressions.  The last statement
-        // in the statement expression is also a block-level expr.
-        if (const StmtExpr* S = dyn_cast<StmtExpr>(E)) {
+  // Iterate over the statements again on identify the Expr* and Stmt* at
+  // the block-level that are block-level expressions.
+  for (CFG::iterator I=cfg.begin(), E=cfg.end(); I != E; ++I)
+    for (CFGBlock::iterator BI=I->begin(), EI=I->end(); BI != EI; ++BI)
+      if (Expr* E = dyn_cast<Expr>(*BI)) {
+        
+        if (BinaryOperator* B = dyn_cast<BinaryOperator>(E)) {
+          // Assignment expressions that are not nested within another
+          // expression are really "statements" whose value is never
+          // used by another expression.
+          if (B->isAssignmentOp() && !SubExprAssignments.count(E))
+            continue;
+        }
+        else if (const StmtExpr* S = dyn_cast<StmtExpr>(E)) {
+          // Special handling for statement expressions.  The last statement
+          // in the statement expression is also a block-level expr.
           const CompoundStmt* C = S->getSubStmt();
           if (!C->body_empty()) {
-            x = M->size();
+            unsigned x = M->size();
             (*M)[C->body_back()] = x;
           }
         }
-      }
 
+        unsigned x = M->size();
+        (*M)[E] = x;
+      }
+    
   return M;
 }
 

Modified: cfe/trunk/Analysis/UninitializedValues.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/Analysis/UninitializedValues.cpp?rev=46380&r1=46379&r2=46380&view=diff

==============================================================================
--- cfe/trunk/Analysis/UninitializedValues.cpp (original)
+++ cfe/trunk/Analysis/UninitializedValues.cpp Fri Jan 25 18:03:27 2008
@@ -201,9 +201,9 @@
 }
 
 bool TransferFuncs::BlockStmt_VisitExpr(Expr* E) {
-  assert (AD.isTracked(E));
-  return V(E,AD) = 
-    static_cast<CFGStmtVisitor<TransferFuncs,bool>*>(this)->Visit(E);
+  bool x = static_cast<CFGStmtVisitor<TransferFuncs,bool>*>(this)->Visit(E);  
+  if (AD.isTracked(E)) V(E,AD) = x;
+  return x;
 }
   
 } // end anonymous namespace