[cfe-commits] [PATCH] simplify the bitfield codegen (for review)
Devang Patel
dpatel at apple.com
Mon Jan 21 14:38:03 PST 2008
On Jan 21, 2008, at 2:23 PM, Lauro Ramos Venancio wrote:
>>
>> Why are you removing 'No' field here ?
>>
>
> Because we can retrieve the No from "FieldInfo" map.
ok.
I prefer to have comments like
- // This is : struct { char a; int b:10; int c:18; };
- // where 'b' shares first field with 'a'. However 'c' needs
- // new llvm field.
Please add them appropriately. Otherwise patch looks good.
Thanks!
-
Devang
More information about the cfe-commits
mailing list