[cfe-commits] trivial patch
Chris Lattner
clattner at apple.com
Mon Jan 7 20:13:29 PST 2008
On Jan 7, 2008, at 8:29 AM, Sam Bishop wrote:
> Hi, all.
>
> I've just started studying the clang source code, and I have a trivial
> whitespace suggestion:
Applied, thanks!
-Chris
>
> --- include/clang/Lex/Preprocessor.h (revision 45702)
> +++ include/clang/Lex/Preprocessor.h (working copy)
> @@ -153,7 +153,7 @@
> SelectorTable &getSelectorTable() { return Selectors; }
>
> inline FullSourceLoc getFullLoc(SourceLocation Loc) const {
> - return FullSourceLoc(Loc,getSourceManager());
> + return FullSourceLoc(Loc, getSourceManager());
> }
>
> /// SetCommentRetentionState - Control whether or not the
> preprocessor ...
>
> At first glance this looks like a method call, not a two-item list
> of method
> parameters.
>
> I don't think I would save anyone any time by attaching a patch, but
> it
> seems like readability is important to you, so I thought I'd pass
> this on.
>
> Thanks,
> Sam Bishop
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
More information about the cfe-commits
mailing list