[cfe-commits] r45206 - in /cfe/trunk: clang.xcodeproj/project.pbxproj include/clang/AST/TranslationUnit.h

[Chris Lattner]

On Dec 19, 2007, at 10:07 AM, Ted Kremenek wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=45206&view=rev
> Log:
> Updated locations of TranslationUnit.[cpp,h] in XCode project.
> Added AST/ASTConsumer.cpp to XCode project.

Hi Ted,

> ====================================================================== 
> ========
> --- cfe/trunk/include/clang/AST/TranslationUnit.h (original)
> +++ cfe/trunk/include/clang/AST/TranslationUnit.h Wed Dec 19  
> 12:07:54 2007
>  class TranslationUnit {
> +  // Information to help uniquely identify a translation unit on  
> disk.
> +  // We may also incorporate a UUID in the future.
> +  uint64_t ino;
> +  uint64_t dev;
> +  const char* SourceFile;
> +
> +  // The actual data of the translation unit.


I don't think this is appropriate: the memory representation and disk  
representations of a TU should be separated.  Info about reading/ 
writing and representing it on a disk should be layered on top of TU,  
not embedded in it.

-Chris