[cfe-commits] r44790 - /cfe/trunk/include/clang/AST/TargetBuiltins.h

Chris Lattner clattner at apple.com
Mon Dec 10 10:55:41 PST 2007


On Dec 10, 2007, at 12:48 AM, Anders Carlsson wrote:

> Author: andersca
> Date: Mon Dec 10 02:48:18 2007
> New Revision: 44790
>
> URL: http://llvm.org/viewvc/llvm-project?rev=44790&view=rev
> Log:
> Forgot this file.

Hi Anders,

> @@ -0,0 +1,30 @@
> +//===--- Targets.cpp - Implement -arch option and targets  
> -----------------===//

Please update the first line in the file.

> +//
> +//                     The LLVM Compiler Infrastructure
> +//
> +// This file was developed by Chris Lattner and is distributed under

s/chris/anders/

> +// the University of Illinois Open Source License. See LICENSE.TXT  
> for details.
> +//
> +// 
> ===------------------------------------------------------------------- 
> ---===//
> +
> +#include "clang/AST/Builtins.h"

Please add an include guard.


> +/// X86 builtins
> +namespace X86 {

Please wrap this in 'namespace clang'.

Thanks!

-Chris





More information about the cfe-commits mailing list