[cfe-commits] r43482 - in /cfe/trunk: AST/ASTContext.cpp include/clang/AST/ASTContext.h include/clang/AST/Type.h

[Ted Kremenek]

On Oct 30, 2007, at 10:59 AM, Chris Lattner wrote:

>
> On Oct 29, 2007, at 4:37 PM, Ted Kremenek wrote:
>
>> Author: kremenek
>> Date: Mon Oct 29 18:37:31 2007
>> New Revision: 43482
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=43482&view=rev
>> Log:
>> VariableArrayTypes (VLAs) without a size expression are now uniqued
>> and inserted into a FoldingSet owned by ASTContext.
>
> Nice, thanks Ted.  Do you happen to know if this caused a reduction  
> in the number of types (particularly FunctionType's) that we  
> create?  It occurred to me that not uniquing these would cause us to  
> make different types for these function protos, for example:
>
> void foo(int x[]);
> void bar(int x[]);
>
> -Chris

I didn't benchmark the reduction in types created yet.  Do you have an  
idea of a good test case?