[cfe-commits] r41880 - in /cfe/trunk: AST/Decl.cpp Parse/ParseObjc.cpp Sema/Sema.h Sema/SemaDecl.cpp include/clang/AST/Decl.h

[Chris Lattner]

> URL: http://llvm.org/viewvc/llvm-project?rev=41880&view=rev
> Log:
> Patch for building method declaration nodes. Also fixed a segfault  
> in cocoa.m due
> to use of @property.

Hi Fariborz,

Very nice!  Your code is looking great so let me pick on something  
else :)

> +++ cfe/trunk/AST/Decl.cpp Wed Sep 12 13:23:47 2007
> @@ -164,6 +164,22 @@
> +void ObjcMethodDecl::setMethodParams(ParmVarDecl **NewParamInfo,
> +		       unsigned NumParams) {

It looks like tabs are sneaking in here.  If you're using Xcode, I'd  
suggest setting your indentation settings to:

Xcode -> Prefs -> Indentation

Clear the "tab key inserts tab, not spaces" checkbox
Set tab width = 8
Set indent width = 2.

Setting tab width to 32 or something is a good way to see where tabs  
enter the file.  Alternatively, please use grep to find the tabs in  
the files and expand them out, they occur in other files as well.

Thanks!

-Chris