[cfe-commits] r42362 - in /cfe/trunk/Driver: DiagChecker.cpp clang.cpp clang.h

[Chris Lattner]

Thanks Ted!

-Chris

On Sep 26, 2007, at 1:22 PM, Ted Kremenek wrote:

>
> On Sep 26, 2007, at 11:46 AM, Chris Lattner wrote:
>>
>>> Note that we still have the option "-parse-ast-check" for backwards
>>> comptability with existing test cases.  This option is now  
>>> equivalent to
>>> "-parse-ast -verify".
>>
>> We should move them over and then remove the old option.
>
> Done.
>
>> Can you remove the <memory> #include from clang.h?
>
> Done.
>
>>
>>> @@ -348,6 +346,9 @@
>>> WarnUnusedMacros("Wunused_macros",
>>>          llvm::cl::desc("Warn for unused macros in the main  
>>> translation unit"));
>>>
>>> +static llvm::cl::opt<bool>
>>> +VerifyDiagnostics("verify",
>>> +                  llvm::cl::desc("Verify emitted diagnostics and  
>>> warnings."))
>>
>> Please move this somewhere else (perhaps right after the  
>> ProgAction option).
>
> Done.