[cfe-commits] r42362 - in /cfe/trunk/Driver: DiagChecker.cpp clang.cpp clang.h

Chris Lattner clattner at apple.com
Wed Sep 26 11:46:15 PDT 2007


On Sep 26, 2007, at 11:39 AM, Ted Kremenek wrote:

> Author: kremenek
> Date: Wed Sep 26 13:39:29 2007
> New Revision: 42362
>
> URL: http://llvm.org/viewvc/llvm-project?rev=42362&view=rev
> Log:
> Refactored driver so that any action that is implemented using an
> ASTConsumer can also be verified using the diagnostics checker.  From
> the command line, users may activate diagnostic checking using the
> "-verify" option.  For example, "clang -verify -warn-dead-stores"
> checks if the warnings flagged by the dead store checker match those
> in the comments.

Very nice, thanks Ted!

> Note that we still have the option "-parse-ast-check" for backwards
> comptability with existing test cases.  This option is now  
> equivalent to
> "-parse-ast -verify".

We should move them over and then remove the old option.

Can you remove the <memory> #include from clang.h?

> @@ -348,6 +346,9 @@
>  WarnUnusedMacros("Wunused_macros",
>           llvm::cl::desc("Warn for unused macros in the main  
> translation unit"));
>
> +static llvm::cl::opt<bool>
> +VerifyDiagnostics("verify",
> +                  llvm::cl::desc("Verify emitted diagnostics and  
> warnings."))

Please move this somewhere else (perhaps right after the ProgAction  
option).

-Chris



More information about the cfe-commits mailing list