[cfe-commits] r41894 - in /cfe/trunk: clang.xcodeproj/project.pbxproj include/clang/AST/ASTContext.h

[Steve Naroff]

On Sep 12, 2007, at 5:49 PM, Chris Lattner wrote:

>> Add ASTContext::StringMap<char> to unique selector names.
>
>> +  // 
>> ===------------------------------------------------------------------ 
>> --===//
>> +  //                            Objective-C
>> +  // 
>> ===------------------------------------------------------------------ 
>> --===//
>> +
>> +  /// getSelectorName - Return a uniqued character string for the  
>> selector.
>> +  char &getSelectorName(const char *NameStart, const char  
>> *NameEnd) {
>> +    return SelectorNames.GetOrCreateValue(NameStart,  
>> NameEnd).getValue();
>> +  }
>
> Is this really what you want?  It seems more useful to  
> return .getKeyData(), which is a pointer to the start of the name.
>

It isn't quite right. I need to take a closer look at StringMap and  
look deeper into what we need here...

snaroff

> -Chris