[cfe-commits] r41410 - in /cfe/trunk/Sema: Sema.h SemaExpr.cpp

[Chris Lattner]

Author: lattner
Date: Sat Aug 25 20:18:55 2007
New Revision: 41410

URL: http://llvm.org/viewvc/llvm-project?rev=41410&view=rev
Log:
merge checkrelational and checkequality into CheckCompareOperands, 
to merge duplicate code.

Modified:
    cfe/trunk/Sema/Sema.h
    cfe/trunk/Sema/SemaExpr.cpp

Modified: cfe/trunk/Sema/Sema.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/Sema/Sema.h?rev=41410&r1=41409&r2=41410&view=diff

==============================================================================
--- cfe/trunk/Sema/Sema.h (original)
+++ cfe/trunk/Sema/Sema.h Sat Aug 25 20:18:55 2007
@@ -395,10 +395,8 @@
     Expr *&lex, Expr *&rex, SourceLocation OpLoc, bool isCompAssign = false);
   inline QualType CheckShiftOperands( // C99 6.5.7
     Expr *&lex, Expr *&rex, SourceLocation OpLoc, bool isCompAssign = false);
-  inline QualType CheckRelationalOperands( // C99 6.5.8
-    Expr *&lex, Expr *&rex, SourceLocation OpLoc);
-  inline QualType CheckEqualityOperands( // C99 6.5.9
-    Expr *&lex, Expr *&rex, SourceLocation OpLoc); 
+  inline QualType CheckCompareOperands( // C99 6.5.8/9
+    Expr *&lex, Expr *&rex, SourceLocation OpLoc, bool isRelational);
   inline QualType CheckBitwiseOperands( // C99 6.5.[10...12]
     Expr *&lex, Expr *&rex, SourceLocation OpLoc, bool isCompAssign = false); 
   inline QualType CheckLogicalOperands( // C99 6.5.[13,14]

Modified: cfe/trunk/Sema/SemaExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/Sema/SemaExpr.cpp?rev=41410&r1=41409&r2=41410&view=diff

==============================================================================
--- cfe/trunk/Sema/SemaExpr.cpp (original)
+++ cfe/trunk/Sema/SemaExpr.cpp Sat Aug 25 20:18:55 2007
@@ -1052,10 +1052,10 @@
   return QualType();
 }
 
-inline QualType Sema::CheckRelationalOperands( // C99 6.5.8
-  Expr *&lex, Expr *&rex, SourceLocation loc)
+inline QualType Sema::CheckCompareOperands( // C99 6.5.8
+  Expr *&lex, Expr *&rex, SourceLocation loc, bool isRelational)
 {
-  // C99 6.5.8p3
+  // C99 6.5.8p3 / C99 6.5.9p4
   if (lex->getType()->isArithmeticType() && rex->getType()->isArithmeticType())
     UsualArithmeticConversions(lex, rex);
   else {
@@ -1065,14 +1065,20 @@
   QualType lType = lex->getType();
   QualType rType = rex->getType();
   
-  if (lType->isRealType() && rType->isRealType())
-    return Context.IntTy;
+  if (isRelational) {
+    if (lType->isRealType() && rType->isRealType())
+      return Context.IntTy;
+  } else {
+    if (lType->isArithmeticType() && rType->isArithmeticType())
+      return Context.IntTy;
+  }
   
   bool LHSIsNull = lex->isNullPointerConstant(Context);
   bool RHSIsNull = rex->isNullPointerConstant(Context);
   
-  // All of the following pointer related warnings are GCC extensions. One
-  // day, we can consider making them errors (when -pedantic-errors is enabled).
+  // All of the following pointer related warnings are GCC extensions, except
+  // when handling null pointer constants. One day, we can consider making them
+  // errors (when -pedantic-errors is enabled).
   if (lType->isPointerType() && rType->isPointerType()) {
     if (!LHSIsNull && !RHSIsNull &&
         !Type::pointerTypesAreCompatible(lType, rType)) {
@@ -1103,59 +1109,6 @@
   return QualType();
 }
 
-inline QualType Sema::CheckEqualityOperands( // C99 6.5.9
-  Expr *&lex, Expr *&rex, SourceLocation loc)
-{
-  // C99 6.5.9p4
-  if (lex->getType()->isArithmeticType() && rex->getType()->isArithmeticType())
-    UsualArithmeticConversions(lex, rex);
-  else {
-    UsualUnaryConversions(lex);
-    UsualUnaryConversions(rex);
-  }
-  QualType lType = lex->getType();
-  QualType rType = rex->getType();
-  
-  if (lType->isArithmeticType() && rType->isArithmeticType())
-    return Context.IntTy;
-    
-  bool LHSIsNull = lex->isNullPointerConstant(Context);
-  bool RHSIsNull = rex->isNullPointerConstant(Context);
-
-  // All of the following pointer related warnings are GCC extensions. One
-  // day, we can consider making them errors (when -pedantic-errors is enabled).
-  if (lType->isPointerType() && rType->isPointerType()) {
-    if (!LHSIsNull && !RHSIsNull &&
-        !Type::pointerTypesAreCompatible(lType, rType)) {
-      Diag(loc, diag::ext_typecheck_comparison_of_distinct_pointers,
-           lType.getAsString(), rType.getAsString(),
-           lex->getSourceRange(), rex->getSourceRange());
-    }
-    promoteExprToType(rex, lType); // promote the pointer to pointer
-    return Context.IntTy;
-  }
-  if (lType->isPointerType() && rType->isIntegerType()) {
-    if (!RHSIsNull) {
-      Diag(loc, diag::ext_typecheck_comparison_of_pointer_integer,
-           lType.getAsString(), rType.getAsString(),
-           lex->getSourceRange(), rex->getSourceRange());
-    }
-    promoteExprToType(rex, lType); // promote the integer to pointer
-    return Context.IntTy;
-  }
-  if (lType->isIntegerType() && rType->isPointerType()) {
-    if (!LHSIsNull) {
-      Diag(loc, diag::ext_typecheck_comparison_of_pointer_integer,
-           lType.getAsString(), rType.getAsString(),
-           lex->getSourceRange(), rex->getSourceRange());
-    }
-    promoteExprToType(lex, rType); // promote the integer to pointer
-    return Context.IntTy;
-  }
-  InvalidOperands(loc, lex, rex);
-  return QualType();
-}
-
 inline QualType Sema::CheckBitwiseOperands(
   Expr *&lex, Expr *&rex, SourceLocation loc, bool isCompAssign) 
 {
@@ -1494,11 +1447,11 @@
   case BinaryOperator::LT:
   case BinaryOperator::GE:
   case BinaryOperator::GT:
-    ResultTy = CheckRelationalOperands(lhs, rhs, TokLoc);
+    ResultTy = CheckCompareOperands(lhs, rhs, TokLoc, true);
     break;
   case BinaryOperator::EQ:
   case BinaryOperator::NE:
-    ResultTy = CheckEqualityOperands(lhs, rhs, TokLoc);
+    ResultTy = CheckCompareOperands(lhs, rhs, TokLoc, false);
     break;
   case BinaryOperator::And:
   case BinaryOperator::Xor: