[cfe-commits] r39994 - /cfe/trunk/AST/Expr.cpp

[Chris Lattner]

Author: lattner
Date: Wed Jul 18 00:21:20 2007
New Revision: 39994

URL: http://llvm.org/viewvc/llvm-project?rev=39994&view=rev
Log:
add a note Neil pointed out

Modified:
    cfe/trunk/AST/Expr.cpp

Modified: cfe/trunk/AST/Expr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/AST/Expr.cpp?rev=39994&r1=39993&r2=39994&view=diff

==============================================================================
--- cfe/trunk/AST/Expr.cpp (original)
+++ cfe/trunk/AST/Expr.cpp Wed Jul 18 00:21:20 2007
@@ -277,6 +277,10 @@
 ///
 /// FIXME: This should ext-warn on overflow during evaluation!  ISO C does not
 /// permit this.
+///
+/// FIXME: Handle offsetof.  Two things to do:  Handle GCC's __builtin_offsetof
+/// to support gcc 4.0+  and handle the idiom GCC recognizes with a null pointer
+/// cast+dereference.
 bool Expr::isIntegerConstantExpr(llvm::APSInt &Result, ASTContext &Ctx,
                                  SourceLocation *Loc, bool isEvaluated) const {
   switch (getStmtClass()) {