[all-commits] [llvm/llvm-project] a7ac94: [flang] Plugin directives: address review comments

[Valentin Churavy via All-commits]

  Branch: refs/heads/users/vchuravy/flang-plugin-directives
  Home:   https://github.com/llvm/llvm-project
  Commit: a7ac947586bb62cbfa4997d91afb9b3f9d18e505
      https://github.com/llvm/llvm-project/commit/a7ac947586bb62cbfa4997d91afb9b3f9d18e505
  Author: Valentin Churavy <v.churavy at gmail.com>
  Date:   2026-10-03 (Sat, 03 Oct 2026)

  Changed paths:
    M flang/lib/Lower/Bridge.cpp
    M flang/lib/Parser/Fortran-parsers.cpp
    M flang/lib/Semantics/mod-file.cpp
    M flang/lib/Semantics/resolve-names.cpp

  Log Message:
  -----------
  [flang] Plugin directives: address review comments

- Accept as procedure arguments only subprograms and external procedures:
  reject dummy procedures, procedure pointers, statement functions and
  intrinsics; a generic name stands for its specific procedure of the same
  name, and is an error without one. Accept as variable arguments only
  variables (not e.g. derived types or module names). Lowering no longer
  calls mangleName on anything else, which aborted.
- Make a malformed argument list of a directive with a registered prefix a
  parse error instead of an ignored, unrecognized directive.
- Leave out of a module file a directive whose arguments are not visible in
  the module (e.g. an internal procedure or a dummy argument), with a
  warning, instead of writing a module file that cannot be read.
- In a function without a RESULT clause, take its name as the function, not
  its result variable, where a procedure may be meant.
- Record a directive on the host's symbol when its subject is host
  associated (a module procedure naming itself), so it is written to the
  module file.

Co-Authored-By: Claude Opus 5.5 <noreply at anthropic.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications