[all-commits] [llvm/llvm-project] c1baa6: [SanitizerCoverage] Don't let noipa affect comdat ...

David Blaikie via All-commits all-commits at lists.llvm.org
Thu Oct 1 15:19:47 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c1baa612dd11cc3c3903b79a04902491d96f9d49
      https://github.com/llvm/llvm-project/commit/c1baa612dd11cc3c3903b79a04902491d96f9d49
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2026-10-01 (Thu, 01 Oct 2026)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
    M llvm/test/Instrumentation/SanitizerCoverage/interposable-symbol.ll

  Log Message:
  -----------
  [SanitizerCoverage] Don't let noipa affect comdat selection (#228182)

On non-ELF targets, SanitizerCoverage only puts a function's coverage
arrays in a comdat if the function isn't interposable.
`isInterposable()`
also returns true for `noipa` function definitions by default, but
`noipa` doesn't affect linkage. Query
`isInterposable(/*CheckNoIPA=*/false)` so `noipa` functions get the same
comdat treatment as other functions with the same linkage.

This is one of a few refinements of noipa identified while working on
making optnone imply noipa - without these refinements,
optnone-implies-noipa, might substantially change clang -O0 codegen. I'm
open to discussing whether these refinements are the right direction,
though.

Assisted-By: Claude



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list