[all-commits] [llvm/llvm-project] 91d88a: [CIR] Preserve padding bytes across a byval argume...

Adam Smith via All-commits all-commits at lists.llvm.org
Wed Sep 30 10:27:43 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 91d88a48f449d54b5004c83399dc2281cb549734
      https://github.com/llvm/llvm-project/commit/91d88a48f449d54b5004c83399dc2281cb549734
  Author: Adam Smith <adams at nvidia.com>
  Date:   2026-09-30 (Wed, 30 Sep 2026)

  Changed paths:
    M clang/lib/CIR/Dialect/Transforms/TargetLowering/CIRABIRewriteContext.cpp
    M clang/lib/CIR/Dialect/Transforms/TargetLowering/CIRABIRewriteContext.h
    M clang/lib/CIR/Dialect/Transforms/TargetLowering/CMakeLists.txt
    A clang/test/CIR/CodeGen/call-conv-lowering-x86_64-byval-union-padding.c
    A clang/test/CIR/CodeGen/call-conv-lowering-x86_64-byval-union-padding.cpp
    M clang/test/CIR/CodeGen/call-conv-lowering-x86_64-non-byval.cpp
    M clang/test/CIR/CodeGen/call-conv-lowering-x86_64-union-tail-padding.c
    M clang/test/CIR/CodeGen/call-conv-lowering-x86_64-variadic.c
    M clang/test/CIR/CodeGen/call.c
    M clang/test/CIR/Transforms/abi-lowering/indirect-byval.cir
    M clang/test/CIR/Transforms/abi-lowering/indirect-call.cir
    M clang/test/CIR/Transforms/abi-lowering/indirect-non-byval-forward-param.cir
    M clang/test/CIR/Transforms/abi-lowering/x86_64-bitint.cir
    M clang/test/CIR/Transforms/abi-lowering/x86_64-struct-indirect.cir
    M clang/test/CIR/Transforms/abi-lowering/x86_64-union.cir

  Log Message:
  -----------
  [CIR] Preserve padding bytes across a byval argument (#224672)

Fill the parameter's own slot in the callee with a copy from the
object's address rather than a store of a loaded record value. At the
call site, pass the object's own address, or fill the byval slot the
same way when it cannot be passed. A store writes only the fields of the
record's type and leaves its padding unwritten, which for a union can be
another member's live data. A _BitInt keeps its load and store, since
those are its conversion to and from memory.

Assisted-by: Cursor / claude-opus-5



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list