[all-commits] [llvm/llvm-project] f04c8d: [flang] Address review comments on the pipeline co...

Valentin Churavy via All-commits all-commits at lists.llvm.org
Wed Sep 30 03:12:44 PDT 2026


  Branch: refs/heads/users/vchuravy/hlfir-pipeline-plugin-example
  Home:   https://github.com/llvm/llvm-project
  Commit: f04c8d96179e4c732f1cbe2ca16a8f91948a45d0
      https://github.com/llvm/llvm-project/commit/f04c8d96179e4c732f1cbe2ca16a8f91948a45d0
  Author: Valentin Churavy <v.churavy at gmail.com>
  Date:   2026-09-30 (Wed, 30 Sep 2026)

  Changed paths:
    M flang/docs/FlangDriver.md
    M flang/include/flang/Optimizer/Passes/Pipelines.h
    M flang/lib/Frontend/FrontendActions.cpp
    M flang/lib/Optimizer/Passes/Pipelines.cpp
    M flang/unittests/Optimizer/HLFIRExtensionPointsTest.cpp

  Log Message:
  -----------
  [flang] Address review comments on the pipeline config callbacks

- Adopt the suggested doc comment wording and name the callback type
  (PassPipelineConfigCallback) instead of spelling std::function / auto.
- Run the callbacks in generateLLVMIR once the config is fully set up, so a
  plugin sees the OpenMP/OpenACC, vscale and other settings as on -emit-fir.
- Document that -emit-fir only reaches the HLFIR extension points, that
  callbacks must not register callbacks, and that bbc/tco/fir-opt do not run
  the registry.
- Tests: drop the redundant epRan flag and use a plain global recorder.

Assisted-by: Claude Code (Opus 5.5)


  Commit: ab60f7c60f2c4fc88d8f5c0e11ec94845b549b6b
      https://github.com/llvm/llvm-project/commit/ab60f7c60f2c4fc88d8f5c0e11ec94845b549b6b
  Author: Valentin Churavy <v.churavy at gmail.com>
  Date:   2026-09-30 (Wed, 30 Sep 2026)

  Changed paths:
    M flang/docs/FlangDriver.md
    M flang/include/flang/Optimizer/Passes/Pipelines.h
    M flang/lib/Frontend/FrontendActions.cpp
    M flang/lib/Optimizer/Passes/Pipelines.cpp
    M flang/unittests/Optimizer/HLFIRExtensionPointsTest.cpp

  Log Message:
  -----------
  Merge the review fixes of the base PR


  Commit: 7466b2fff494d83d45ae7976bde5bdc626dc79c5
      https://github.com/llvm/llvm-project/commit/7466b2fff494d83d45ae7976bde5bdc626dc79c5
  Author: Valentin Churavy <v.churavy at gmail.com>
  Date:   2026-09-30 (Wed, 30 Sep 2026)

  Changed paths:
    M flang/examples/HLFIRPipelinePlugin/HLFIRPipelinePlugin.cpp
    M flang/test/Examples/fir-opt-pass-plugin.fir
    M flang/test/Examples/hlfir-pipeline-plugin.f90

  Log Message:
  -----------
  [flang] Address review comments on the HLFIR pipeline example plugin

- Rename the pass to print-hlfir-ops: it prints every hlfir op, not only the
  intrinsics.
- Drop the redundant option copy in the copy constructor; Pass::clone copies
  option values.
- Tests: drop the no-plugin run, which could not fail, and at -O2 only check
  that both extension points are reached rather than what
  SimplifyHLFIRIntrinsics chose to expand.

Assisted-by: Claude Code (Opus 5.5)


Compare: https://github.com/llvm/llvm-project/compare/323a51dd33b1...7466b2fff494

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list