[all-commits] [llvm/llvm-project] f87fd4: [lldb/Interpreter] Report scripted hook failures v...

[Med Ismail Bennani via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f87fd43dbd9bbd5b7ad2bc9762eb7c969f48c263
      https://github.com/llvm/llvm-project/commit/f87fd43dbd9bbd5b7ad2bc9762eb7c969f48c263
  Author: Med Ismail Bennani <ismail at bennani.ma>
  Date:   2026-09-29 (Tue, 29 Sep 2026)

  Changed paths:
    M lldb/include/lldb/Interpreter/Interfaces/ScriptedHookInterface.h
    M lldb/source/Target/Target.cpp
    M lldb/test/API/functionalities/scripted_extensions/TestScriptedExtensionsDiagnostics.py

  Log Message:
  -----------
  [lldb/Interpreter] Report scripted hook failures via Debugger::ReportError (#227508)

This patch addresses post-merge feedback on #225292.

`ReportScriptedHookError` formatted the error through a
`CommandReturnObject` whose immediate streams pointed at the hook's
output stream. Since no command is involved, this patch reports the
failure with `Debugger::ReportError` instead, which is the diagnostic
channel other scripted extensions already use when they have no caller
to return an error to.

This patch also makes the default `HandleModuleLoaded` and
`HandleModuleUnloaded` implementations in `ScriptedHookInterface` return
`llvm::errc::not_supported` rather than success, since they are only
invoked when the scripted class implements the corresponding method.

The scripted stop hook tests now assert on the diagnostic event rather
than on the debugger's output.

Signed-off-by: Med Ismail Bennani <ismail at bennani.ma>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications