[all-commits] [llvm/llvm-project] 71879b: [BOLT] Keep instrumentation diagnostics out of lin...
Ilias via All-commits
all-commits at lists.llvm.org
Tue Sep 29 16:52:35 PDT 2026
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 71879b956485cb1501a3d994c17b3f581760c95b
https://github.com/llvm/llvm-project/commit/71879b956485cb1501a3d994c17b3f581760c95b
Author: Ilias <iliasaberkane6 at gmail.com>
Date: 2026-09-29 (Tue, 29 Sep 2026)
Changed paths:
M bolt/runtime/common.h
Log Message:
-----------
[BOLT] Keep instrumentation diagnostics out of line (#225986)
The instrumentation runtime's diagnostics reserve a 32 KiB scratch
buffer on the stack. When `assert()` or `reportNumber()` get inlined
into callers on instrumented code paths, the buffer inflates every
caller frame — on small thread stacks a single such frame already
overflows the guard region and the profiled binary segfaults even when
no assertion fires.
Move the `assert()` failure path into a `noinline` helper
(`reportAssertFailure`) and mark `reportNumber()` `noinline` as well, so
the scratch buffer is only reserved when a diagnostic is actually
emitted. This matches the fix sketched in the issue report.
Verified: `common.h` syntax-checks clean in the freestanding runtime
build; the only behavioral change is where the buffer lives.
Fixes #225479
AI assistance: AI tools helped prepare this contribution. The author
reviewed the final patch and remains responsible for it, in accordance
with the LLVM AI Tool Use Policy.
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list