[all-commits] [llvm/llvm-project] 024043: [lldb][Windows] Register the shadow listener in Pl...

[Charles Zablit via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 02404370e82a97c43b2edc858cd79d042e85da6a
      https://github.com/llvm/llvm-project/commit/02404370e82a97c43b2edc858cd79d042e85da6a
  Author: Charles Zablit <c_zablit at apple.com>
  Date:   2026-09-29 (Tue, 29 Sep 2026)

  Changed paths:
    M lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp

  Log Message:
  -----------
  [lldb][Windows] Register the shadow listener in PlatformWindows (#227277)

`PlatformWindows::DebugProcess` and `PlatformWindows::Attach` create the
Process and hijack its events, but never call
`Process::SetShadowListener` with the listener from the launch or attach
info. `PlatformPOSIX`, `PlatformRemoteGDBServer` and `Target::Launch`'s
all do.

On Windows a shadow listener set with `SBLaunchInfo::SetShadowListener`
therefore never gets an event, which is why
`TestEvents.test_shadow_listener` failed on every run (`"Shadow listener
got event too"`) on both the lldb-server and the in-process backend.
    
Call `SetShadowListener` in both, and in Attach only touch `process_sp`
once it is known to be non-null (HijackProcessEvents was called before
the null check).

I was able to reproduce the failure at desk on a machine that's under
load. The issue no longer reproduces after this patch.

Fixes https://github.com/llvm/llvm-project/issues/37721.

rdar://188700614



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications