[all-commits] [llvm/llvm-project] 36a70a: [CIR][CodeGen][NFC] Retire the CodeGenUtils.h catc...

[Henrich Lauko via All-commits]

  Branch: refs/heads/users/xlauko/cgutils-09-retire-umbrella
  Home:   https://github.com/llvm/llvm-project
  Commit: 36a70a9c20b6ba5b9073539e4c4b18e596bf4ed5
      https://github.com/llvm/llvm-project/commit/36a70a9c20b6ba5b9073539e4c4b18e596bf4ed5
  Author: Henrich Lauko <hlauko at nvidia.com>
  Date:   2026-09-29 (Tue, 29 Sep 2026)

  Changed paths:
    M clang/include/clang/CodeGenUtils/ClassUtils.h
    R clang/include/clang/CodeGenUtils/CodeGenUtils.h
    M clang/include/clang/CodeGenUtils/FunctionUtils.h
    M clang/include/clang/CodeGenUtils/ModuleUtils.h
    M clang/include/clang/CodeGenUtils/TargetUtils.h
    M clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp
    M clang/lib/CIR/CodeGen/CIRGenClass.cpp
    M clang/lib/CIR/CodeGen/CIRGenExpr.cpp
    M clang/lib/CIR/CodeGen/CIRGenFunction.cpp
    M clang/lib/CIR/CodeGen/CIRGenModule.cpp
    M clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
    M clang/lib/CodeGen/CGClass.cpp
    M clang/lib/CodeGen/CGExpr.cpp
    M clang/lib/CodeGen/CGRecordLayoutBuilder.cpp
    M clang/lib/CodeGen/CodeGenFunction.cpp
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/lib/CodeGenUtils/CMakeLists.txt
    M clang/lib/CodeGenUtils/ClassUtils.cpp
    R clang/lib/CodeGenUtils/CodeGenUtils.cpp
    M clang/lib/CodeGenUtils/FunctionUtils.cpp
    M clang/lib/CodeGenUtils/ModuleUtils.cpp
    M clang/lib/CodeGenUtils/TargetUtils.cpp

  Log Message:
  -----------
  [CIR][CodeGen][NFC] Retire the CodeGenUtils.h catch-all header

The preceding patches group shared helpers by the classic CodeGen file, or
file family, they came from. That leaves CodeGenUtils.h holding only the
five helpers PR #221001 started the library with and the target-features
checker from PR #223056, so they move to the same places their neighbours
went and the header goes away. The library keeps its name.

checkTargetFeatures came out of CodeGenFunction.cpp, so it joins
shouldEmitLifetimeMarkers in FunctionUtils.h. TargetUtils.h would fit it by
subject, but the series sorts by origin file, and picking origin keeps the
rule mechanical.

isAAPCS is the one case origin does not settle, since it was duplicated in
CGExpr.cpp and CGRecordLayoutBuilder.cpp rather than living in one file. It
is a plain TargetInfo predicate, so it goes with the other target
predicates.

Doing this now avoids making every helper we share from here on pick
between the catch-all and a themed header, with no rule saying which. It
only moves code already on main, so it can be dropped without affecting the
patches before it.

No functional change intended.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications