[all-commits] [llvm/llvm-project] d94f3a: [orc-rt] Make socket unit tests portable; build th...

[Lang Hames via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d94f3a52dad756d7354a9ca688b4ac76a97b9d38
      https://github.com/llvm/llvm-project/commit/d94f3a52dad756d7354a9ca688b4ac76a97b9d38
  Author: Lang Hames <lhames at gmail.com>
  Date:   2026-09-26 (Sat, 26 Sep 2026)

  Changed paths:
    M orc-rt/test/unit/CMakeLists.txt
    R orc-rt/test/unit/bedrock/SocketConnectorTest.cpp
    M orc-rt/test/unit/bedrock/SocketTestUtils.h
    M orc-rt/test/unit/bedrock/sps/SimpleRemoteCAOverSocketTest.cpp
    A orc-rt/test/unit/bedrock/sys/posix/SocketConnectorTest.cpp
    M orc-rt/test/unit/bedrock/sys/posix/SocketTestUtils.cpp

  Log Message:
  -----------
  [orc-rt] Make socket unit tests portable; build them on POSIX. (#226662)

SimpleRemoteCAOverSocketTest.cpp tests a POSIX-only implementation, so
move it to the POSIX source list. Its tests are portable, so move the
fixture's POSIX code into SocketTestUtils (makeStreamSocketPair,
sendAll, recvAll, makeNativeNonStreamSocket) rather than moving the file
under sys/posix; a Windows transport will need only Windows definitions
of those helpers.

makeStreamSocketPair documents the properties the tests rely on beyond a
connected stream pair: neither direction buffers StallingPayloadSize
bytes, and closing an end delivers what it already sent even if it has
unread data. AF_UNIX provides both; a loopback TCP pair may not.

SocketConnectorTest.cpp tests fd adoption with pipe and fcntl, so it is
a test of the POSIX implementation: move it to sys/posix/.

Assisted-by: Claude



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications